Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow using sr25519 addresses for evm send and other funcs #1605

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

philipsu522
Copy link
Contributor

Describe your changes and provide context

Similar to https://github.com/sei-protocol/sei-cosmos/pull/495/files, priv, err := legacy.PrivKeyFromBytes([]byte(localInfo.PrivKeyArmor)) only works with secp256k1 algo, so we should disallow using sr25519 addresses

Testing performed to validate your change

root@ip-172-31-4-247:/home/ubuntu/sei-chain# printf "12345678\n" | seid tx evm send 0xF87A299e6bC7bEba58dbBe5a5Aa21d49bCD16D52  100000000000000000 --from sei-foundation
Error: can only use addresses using secp256k1

@philipsu522 philipsu522 requested review from codchen and udpatil April 29, 2024 16:36
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 61.09%. Comparing base (9df725e) to head (40293d7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1605   +/-   ##
=======================================
  Coverage   61.08%   61.09%           
=======================================
  Files         365      365           
  Lines       26104    26107    +3     
=======================================
+ Hits        15945    15949    +4     
+ Misses       9154     9153    -1     
  Partials     1005     1005           
Files Coverage Δ
evmrpc/utils.go 76.04% <0.00%> (-1.21%) ⬇️

... and 1 file with indirect coverage changes

@philipsu522 philipsu522 merged commit 5b9e025 into main Apr 29, 2024
47 checks passed
@philipsu522 philipsu522 deleted the seid-tx-evm-send branch April 29, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants