Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ante Handler: Nested Evm Messages within Authz #1472

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Mar 26, 2024

Describe your changes and provide context

  • Ante handler to reject authz msg Execs which contain nested evm messages

Testing performed to validate your change

  • Added unit tests
  • Verifying e2e

@Kbhat1 Kbhat1 requested a review from codchen March 26, 2024 13:08
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.17073% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 62.26%. Comparing base (cd3e074) to head (bccf485).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            seiv2    #1472      +/-   ##
==========================================
+ Coverage   62.04%   62.26%   +0.22%     
==========================================
  Files         352      353       +1     
  Lines       24402    24443      +41     
==========================================
+ Hits        15140    15220      +80     
+ Misses       8398     8347      -51     
- Partials      864      876      +12     
Files Coverage Δ
app/ante.go 55.55% <100.00%> (+0.55%) ⬆️
app/antedecorators/authz_nested_message.go 72.50% <72.50%> (ø)

... and 3 files with indirect coverage changes

@Kbhat1 Kbhat1 requested a review from philipsu522 March 27, 2024 15:27
@Kbhat1 Kbhat1 merged commit 226c073 into seiv2 Mar 27, 2024
38 checks passed
@Kbhat1 Kbhat1 deleted the AuthzEvmMessages branch March 27, 2024 16:43
udpatil pushed a commit that referenced this pull request Mar 27, 2024
* Authz Nested Evm Messages

* Update comments
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* Authz Nested Evm Messages

* Update comments
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* Authz Nested Evm Messages

* Update comments
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* Authz Nested Evm Messages

* Update comments
udpatil pushed a commit that referenced this pull request Apr 18, 2024
* Authz Nested Evm Messages

* Update comments
udpatil pushed a commit that referenced this pull request Apr 19, 2024
* Authz Nested Evm Messages

* Update comments
udpatil pushed a commit that referenced this pull request Apr 19, 2024
* Authz Nested Evm Messages

* Update comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants