Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update that brings go-ethereum with live tracer support #1375

Conversation

maoueh
Copy link
Contributor

@maoueh maoueh commented Feb 23, 2024

Describe your changes and provide context

This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt DBImpl to support the new interface.

Relates to:

This makes the necessary changes in sei-chain to bump go-ethereum to the upcoming version with enhanced EVM tracing.

Testing performed to validate your change

Run unit tests. evmrpc/tracers_test.go:20 test TestTraceTransaction fails, the gasLimit seems not populated correctly now. I need to investigate further as I don't quite understand actually how it's passing before.

I wanted to open the PR sooner than later, I'll fix the test tomorrow.

@maoueh maoueh marked this pull request as draft February 23, 2024 00:40
@maoueh
Copy link
Contributor Author

maoueh commented Feb 23, 2024

Test that was failing around tracer has been fixed. I now get a failure with TestMint but I checked quickly the code, I don't see how bumping go-ethereum dependency would have affected that test.

--- FAIL: TestMint (6.02s)
    mint.go:35:
                Error Trace:    /Users/maoueh/work/sf/sei/chain/testutil/processblock/verify/mint.go:35
                                                        /Users/maoueh/work/sf/sei/chain/tests/template_test.go:25
                                                        /Users/maoueh/work/sf/sei/chain/tests/mint_test.go:38
                Error:          Not equal:
                                expected: 0x7a120
                                actual  : 0xf4240
                Test:           TestMint

@maoueh maoueh force-pushed the feature/bump-go-ethereum-with-tracer branch from 2897126 to c6137d1 Compare March 15, 2024 21:58
@maoueh maoueh changed the base branch from evm to seiv2 March 15, 2024 21:58
@maoueh maoueh marked this pull request as ready for review March 15, 2024 21:59
@maoueh maoueh force-pushed the feature/bump-go-ethereum-with-tracer branch 2 times, most recently from c79684c to d51b5c3 Compare March 19, 2024 14:37
maoueh added 2 commits March 27, 2024 15:45
This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface.

Relates to:
- sei-protocol/go-ethereum#15
- sei-protocol#1344
@maoueh maoueh force-pushed the feature/bump-go-ethereum-with-tracer branch from 064f29d to 83f7afe Compare March 27, 2024 19:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 25.53191% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 61.64%. Comparing base (eb56128) to head (83f7afe).
Report is 215 commits behind head on seiv2.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            seiv2    #1375      +/-   ##
==========================================
- Coverage   62.87%   61.64%   -1.23%     
==========================================
  Files         350      355       +5     
  Lines       23965    24745     +780     
==========================================
+ Hits        15068    15255     +187     
- Misses       8029     8606     +577     
- Partials      868      884      +16     
Files Coverage Δ
evmrpc/simulate.go 70.08% <100.00%> (ø)
app/eth_replay.go 0.00% <0.00%> (ø)
x/evm/state/log.go 81.25% <25.00%> (-18.75%) ⬇️
x/evm/state/state.go 94.91% <40.00%> (-2.34%) ⬇️
x/evm/state/statedb.go 46.42% <0.00%> (-1.72%) ⬇️
x/evm/state/nonce.go 63.63% <20.00%> (-36.37%) ⬇️
x/evm/state/code.go 65.00% <12.50%> (-35.00%) ⬇️
x/evm/state/balance.go 58.53% <26.31%> (-10.70%) ⬇️

... and 30 files with indirect coverage changes

@stevenlanders stevenlanders merged commit eb2080b into sei-protocol:seiv2 Mar 29, 2024
38 of 39 checks passed
@maoueh maoueh deleted the feature/bump-go-ethereum-with-tracer branch March 29, 2024 13:56
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* Update that brings `go-ethereum` with live tracer support

This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface.

Relates to:
- sei-protocol/go-ethereum#15
- #1344

* Added missing instrumentation when state changes in `DBImpl`
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* Update that brings `go-ethereum` with live tracer support

This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface.

Relates to:
- sei-protocol/go-ethereum#15
- #1344

* Added missing instrumentation when state changes in `DBImpl`
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* Update that brings `go-ethereum` with live tracer support

This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface.

Relates to:
- sei-protocol/go-ethereum#15
- #1344

* Added missing instrumentation when state changes in `DBImpl`
udpatil pushed a commit that referenced this pull request Apr 18, 2024
* Update that brings `go-ethereum` with live tracer support

This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface.

Relates to:
- sei-protocol/go-ethereum#15
- #1344

* Added missing instrumentation when state changes in `DBImpl`
udpatil pushed a commit that referenced this pull request Apr 19, 2024
* Update that brings `go-ethereum` with live tracer support

This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface.

Relates to:
- sei-protocol/go-ethereum#15
- #1344

* Added missing instrumentation when state changes in `DBImpl`
udpatil pushed a commit that referenced this pull request Apr 19, 2024
* Update that brings `go-ethereum` with live tracer support

This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface.

Relates to:
- sei-protocol/go-ethereum#15
- #1344

* Added missing instrumentation when state changes in `DBImpl`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants