-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update that brings go-ethereum
with live tracer support
#1375
Update that brings go-ethereum
with live tracer support
#1375
Conversation
Test that was failing around
|
2897126
to
c6137d1
Compare
c79684c
to
d51b5c3
Compare
This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface. Relates to: - sei-protocol/go-ethereum#15 - sei-protocol#1344
064f29d
to
83f7afe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## seiv2 #1375 +/- ##
==========================================
- Coverage 62.87% 61.64% -1.23%
==========================================
Files 350 355 +5
Lines 23965 24745 +780
==========================================
+ Hits 15068 15255 +187
- Misses 8029 8606 +577
- Partials 868 884 +16
|
* Update that brings `go-ethereum` with live tracer support This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface. Relates to: - sei-protocol/go-ethereum#15 - #1344 * Added missing instrumentation when state changes in `DBImpl`
* Update that brings `go-ethereum` with live tracer support This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface. Relates to: - sei-protocol/go-ethereum#15 - #1344 * Added missing instrumentation when state changes in `DBImpl`
* Update that brings `go-ethereum` with live tracer support This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface. Relates to: - sei-protocol/go-ethereum#15 - #1344 * Added missing instrumentation when state changes in `DBImpl`
* Update that brings `go-ethereum` with live tracer support This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface. Relates to: - sei-protocol/go-ethereum#15 - #1344 * Added missing instrumentation when state changes in `DBImpl`
* Update that brings `go-ethereum` with live tracer support This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface. Relates to: - sei-protocol/go-ethereum#15 - #1344 * Added missing instrumentation when state changes in `DBImpl`
* Update that brings `go-ethereum` with live tracer support This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt `DBImpl` to support the new interface. Relates to: - sei-protocol/go-ethereum#15 - #1344 * Added missing instrumentation when state changes in `DBImpl`
Describe your changes and provide context
This only brings the dependency (will need to wait for a merge + tag of the branch before merging this PR) and the required changes to adapt
DBImpl
to support the new interface.Relates to:
This makes the necessary changes in
sei-chain
to bumpgo-ethereum
to the upcoming version with enhanced EVM tracing.Testing performed to validate your change
Run unit tests.
evmrpc/tracers_test.go:20
testTestTraceTransaction
fails, thegasLimit
seems not populated correctly now. I need to investigate further as I don't quite understand actually how it's passing before.I wanted to open the PR sooner than later, I'll fix the test tomorrow.