[EVM] Add index to logs based on order #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## evm #1273 +/- ##
==========================================
- Coverage 64.02% 64.00% -0.02%
==========================================
Files 346 346
Lines 23072 23073 +1
==========================================
- Hits 14771 14768 -3
- Misses 7465 7467 +2
- Partials 836 838 +2
|
stevenlanders
force-pushed
the
add-support-for-log-index
branch
from
d9b7491 to
d55cd09
Compare
jewei1997
reviewed
Jan 23, 2024
| @@ -428,7 +428,7 @@ describe("EVM Test", function () { | |||
| }); | |||
|
|
|||
| describe("Differing maxPriorityFeePerGas and maxFeePerGas", async function() { | |||
| testCases.forEach(async ([name, maxPriorityFeePerGas, maxFeePerGas]) => { | |||
| for (const [name, maxPriorityFeePerGas, maxFeePerGas] of testCases) { | |||
There was a problem hiding this comment.
Not much, but my ide linter complains that the async function promise wasn't being used, and gave me yellow lines, so I accepted its change suggestion.
jewei1997
approved these changes
Jan 23, 2024
udpatil
pushed a commit
that referenced
this pull request
Jan 31, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
udpatil
pushed a commit
that referenced
this pull request
Mar 4, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
udpatil
pushed a commit
that referenced
this pull request
Mar 4, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
udpatil
pushed a commit
that referenced
this pull request
Mar 11, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
udpatil
pushed a commit
that referenced
this pull request
Mar 26, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
udpatil
pushed a commit
that referenced
this pull request
Apr 18, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
* add index to logs based on order * add check for getLogs * add log conversion test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change