Cleanup removed oracle feeds #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udpatil
requested review from
philipsu522,
stevenlanders,
Kbhat1 and
yzang2019
stevenlanders
approved these changes
Jan 2, 2024
x/oracle/keeper/keeper.go
Outdated
| return false | ||
| }) | ||
| // compare | ||
| activesToClear := []string{} |
There was a problem hiding this comment.
fwiw, idiomatic is defaulting to the nil: var activesToClear []string
| @@ -681,3 +693,123 @@ func TestCalculateTwaps(t *testing.T) { | |||
| require.Error(t, err) | |||
| require.Equal(t, types.ErrInvalidTwapLookback, err) | |||
| } | |||
|
|
|||
| func TestCalculateTwapsWithUnsupportedDenom(t *testing.T) { | |||
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -162,5 +162,7 @@ | |||
| // reset miss counters of all validators at the last block of slash window | |||
| if utils.IsPeriodLastBlock(ctx, params.SlashWindow) { | |||
| k.SlashAndResetCounters(ctx) | |||
| // Compare vote targets and actives and remove excess feeds | |||
| k.RemoveExcessFeeds(ctx) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
==========================================
- Coverage 63.40% 63.35% -0.05%
==========================================
Files 257 257
Lines 16694 16726 +32
==========================================
+ Hits 10585 10597 +12
- Misses 5601 5626 +25
+ Partials 508 503 -5
|
Comment on lines
+137
to
+140
| for denom := range excessActives { | ||
| activesToClear[i] = denom | ||
| i++ | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
yzang2019
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This ensure that oracle feeds are removed at the end of the oracle slashing window IF the asset is no longer whitelisted. Additionally, it prevents the TWAPs endpoint from serving twaps for denoms that are no longer in the whitelist.
Testing performed to validate your change
Unit tests