Add catch all panic handler in dex endblock #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
- Coverage 63.83% 63.38% -0.45%
==========================================
Files 257 257
Lines 16672 16690 +18
==========================================
- Hits 10642 10579 -63
- Misses 5526 5603 +77
- Partials 504 508 +4
|
|
Can we add a metric for panicHandler so that we can monitor and alert on it? |
yzang2019
reviewed
Dec 29, 2023
| @@ -130,16 +129,17 @@ func ExecutePairsInParallel(ctx sdk.Context, contractAddr string, dexkeeper *kee | |||
| cancelResults := []*types.Cancellation{} | |||
| settlements := []*types.SettlementEntry{} | |||
|
|
|||
| mu := sync.Mutex{} | |||
| wg := sync.WaitGroup{} | |||
| // mu := sync.Mutex{} | |||
There was a problem hiding this comment.
We leave them here so that we can revert them in case we need?
philipsu522
approved these changes
Dec 29, 2023
philipsu522
pushed a commit
that referenced
this pull request
Dec 29, 2023
* Add catch all panic handler in dex endblock * test * Add a new counter metric for recovered panics --------- Co-authored-by: yzang2019 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Any panic in EndBlock would cause the chain to halt, so we decide to add back panic recovery handler. Also made executions for multiple pairs sequential for each contract so that panics are easier to manage.
After this fix, there will be:
EndBlockfunction, the main goroutine, with a panic handler at https://github.com/sei-protocol/sei-chain/compare/fix-dex?expand=1#diff-f32c70484252fadec70cda9a6ad7888fd568f6afffb3750bb9621090e2ac88bbR307Testing performed to validate your change