Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tolerance to nil response for error log #1070

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

stevenlanders
Copy link
Contributor

Describe your changes and provide context

  • If the broadcast request returns as nil response, the log statement would panic
  • This makes the log statement tolerant to a nil response, causing a restart

Testing performed to validate your change

  • Reproduced and added unit test

@stevenlanders stevenlanders changed the title Add tolerance to nil for error Add tolerance to nil response for error log Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #1070 (a707c5c) into main (0895bcc) will decrease coverage by 0.06%.
The diff coverage is 73.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
- Coverage   63.63%   63.58%   -0.06%     
==========================================
  Files         256      256              
  Lines       16584    16593       +9     
==========================================
- Hits        10553    10550       -3     
- Misses       5529     5539      +10     
- Partials      502      504       +2     
Files Coverage Δ
oracle/price-feeder/oracle/oracle.go 70.52% <73.33%> (+1.69%) ⬆️

... and 1 file with indirect coverage changes

@stevenlanders stevenlanders merged commit 4fdcf14 into main Sep 26, 2023
@stevenlanders stevenlanders deleted the add-tolerance-to-nil-for-error branch September 26, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants