Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder tx results into absolute order #1018

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Reorder tx results into absolute order #1018

merged 2 commits into from
Aug 7, 2023

Conversation

udpatil
Copy link
Collaborator

@udpatil udpatil commented Aug 7, 2023

Describe your changes and provide context

This reorders the TXResults such that the true order of tx indices is preserves as opposed to ordering parititoned and then other TXs which was occurring previously

Testing performed to validate your change

unit tests + will test patch on chain

app/app.go Outdated Show resolved Hide resolved
@udpatil udpatil enabled auto-merge (squash) August 7, 2023 14:57
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1018 (e95d888) into main (384b94e) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 94.11%.

❗ Current head e95d888 differs from pull request most recent head 7e88c7b. Consider uploading reports for the commit 7e88c7b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
+ Coverage   62.86%   62.89%   +0.02%     
==========================================
  Files         256      256              
  Lines       16486    16490       +4     
==========================================
+ Hits        10364    10371       +7     
+ Misses       5620     5612       -8     
- Partials      502      507       +5     
Files Changed Coverage Δ
x/tokenfactory/client/cli/tx.go 2.95% <0.00%> (-0.02%) ⬇️
app/app.go 77.88% <100.00%> (+0.06%) ⬆️

... and 3 files with indirect coverage changes

@udpatil udpatil merged commit 6a7ba94 into main Aug 7, 2023
@udpatil udpatil deleted the txresult-ordering-fix branch August 7, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants