more tests

x/confidentialtransfers/types/zk.go

@@ -63,6 +63,10 @@ func (c *TransferProofs) ToProto(proofs *Proofs) *TransferProofs {
 }
 
 func (c *TransferProofs) FromProto() (*Proofs, error) {
+	err := c.Validate()
+	if err != nil {
+		return nil, err
+	}
 	remainingBalanceCommitmentValidityProof, err := c.RemainingBalanceCommitmentValidityProof.FromProto()
 	if err != nil {
 		return nil, err
@@ -138,6 +142,10 @@ func (c *CiphertextValidityProof) ToProto(zkp *zkproofs.CiphertextValidityProof)
 }
 
 func (c *CiphertextValidityProof) FromProto() (*zkproofs.CiphertextValidityProof, error) {
+	err := c.Validate()
+	if err != nil {
+		return nil, err
+	}
 	ed25519Curve := curves.ED25519()
 
 	c1, err := ed25519Curve.Point.FromAffineCompressed(c.Commitment_1)
@@ -183,6 +191,10 @@ func (r *RangeProof) ToProto(zkp *zkproofs.RangeProof) *RangeProof {
 }
 
 func (r *RangeProof) FromProto() (*zkproofs.RangeProof, error) {
+	err := r.Validate()
+	if err != nil {
+		return nil, err
+	}
 	ed25519Curve := curves.ED25519()
 	proof := bulletproof.NewRangeProof(ed25519Curve)
 
@@ -222,6 +234,10 @@ func (c *CiphertextCommitmentEqualityProof) ToProto(zkp *zkproofs.CiphertextComm
 }
 
 func (c *CiphertextCommitmentEqualityProof) FromProto() (*zkproofs.CiphertextCommitmentEqualityProof, error) {
+	err := c.Validate()
+	if err != nil {
+		return nil, err
+	}
 	ed25519Curve := curves.ED25519()
 
 	y0, err := ed25519Curve.Point.FromAffineCompressed(c.Y0)
@@ -284,6 +300,10 @@ func (c *CiphertextCiphertextEqualityProof) ToProto(zkp *zkproofs.CiphertextCiph
 }
 
 func (c *CiphertextCiphertextEqualityProof) FromProto() (*zkproofs.CiphertextCiphertextEqualityProof, error) {
+	err := c.Validate()
+	if err != nil {
+		return nil, err
+	}
 	ed25519Curve := curves.ED25519()
 
 	y0, err := ed25519Curve.Point.FromAffineCompressed(c.Y0)
@@ -361,6 +381,10 @@ func (a *Auditor) ToProto(transferAuditor *TransferAuditor) *Auditor {
 }
 
 func (a *Auditor) FromProto() (*TransferAuditor, error) {
+	err := a.Validate()
+	if err != nil {
+		return nil, err
+	}
 	transferAmountLo, err := a.EncryptedTransferAmountLo.FromProto()
 	if err != nil {
 		return nil, err

x/confidentialtransfers/types/zk_test.go

@@ -140,3 +140,123 @@ func TestTransferProofs_Validate(t *testing.T) {
 		})
 	}
 }
+
+func TestTransferProofs_FromProto(t *testing.T) {
+	tests := []struct {
+		name    string
+		proofs  TransferProofs
+		wantErr bool
+		errMsg  string
+	}{
+		{
+			name:    "missing RemainingBalanceCommitmentValidityProof",
+			proofs:  TransferProofs{},
+			wantErr: true,
+			errMsg:  "remaining balance commitment validity proof is required",
+		},
+		{
+			name: "missing SenderTransferAmountLoValidityProof",
+			proofs: TransferProofs{
+				RemainingBalanceCommitmentValidityProof: &CiphertextValidityProof{},
+			},
+			wantErr: true,
+			errMsg:  "sender transfer amount lo validity proof is required",
+		},
+		{
+			name: "missing SenderTransferAmountHiValidityProof",
+			proofs: TransferProofs{
+				RemainingBalanceCommitmentValidityProof: &CiphertextValidityProof{},
+				SenderTransferAmountLoValidityProof:     &CiphertextValidityProof{},
+			},
+			wantErr: true,
+			errMsg:  "sender transfer amount hi validity proof is required",
+		},
+		{
+			name: "missing RecipientTransferAmountLoValidityProof",
+			proofs: TransferProofs{
+				RemainingBalanceCommitmentValidityProof: &CiphertextValidityProof{},
+				SenderTransferAmountLoValidityProof:     &CiphertextValidityProof{},
+				SenderTransferAmountHiValidityProof:     &CiphertextValidityProof{},
+			},
+			wantErr: true,
+			errMsg:  "recipient transfer amount lo validity proof is required",
+		},
+		{
+			name: "missing RecipientTransferAmountHiValidityProof",
+			proofs: TransferProofs{
+				RemainingBalanceCommitmentValidityProof: &CiphertextValidityProof{},
+				SenderTransferAmountLoValidityProof:     &CiphertextValidityProof{},
+				SenderTransferAmountHiValidityProof:     &CiphertextValidityProof{},
+				RecipientTransferAmountLoValidityProof:  &CiphertextValidityProof{},
+			},
+			wantErr: true,
+			errMsg:  "recipient transfer amount hi validity proof is required",
+		},
+		{
+			name: "missing RemainingBalanceRangeProof",
+			proofs: TransferProofs{
+				RemainingBalanceCommitmentValidityProof: &CiphertextValidityProof{},
+				SenderTransferAmountLoValidityProof:     &CiphertextValidityProof{},
+				SenderTransferAmountHiValidityProof:     &CiphertextValidityProof{},
+				RecipientTransferAmountLoValidityProof:  &CiphertextValidityProof{},
+				RecipientTransferAmountHiValidityProof:  &CiphertextValidityProof{},
+			},
+			wantErr: true,
+			errMsg:  "remaining balance range proof is required",
+		},
+		{
+			name: "missing RemainingBalanceEqualityProof",
+			proofs: TransferProofs{
+				RemainingBalanceCommitmentValidityProof: &CiphertextValidityProof{},
+				SenderTransferAmountLoValidityProof:     &CiphertextValidityProof{},
+				SenderTransferAmountHiValidityProof:     &CiphertextValidityProof{},
+				RecipientTransferAmountLoValidityProof:  &CiphertextValidityProof{},
+				RecipientTransferAmountHiValidityProof:  &CiphertextValidityProof{},
+				RemainingBalanceRangeProof:              &RangeProof{},
+			},
+			wantErr: true,
+			errMsg:  "remaining balance equality proof is required",
+		},
+		{
+			name: "missing TransferAmountLoEqualityProof",
+			proofs: TransferProofs{
+				RemainingBalanceCommitmentValidityProof: &CiphertextValidityProof{},
+				SenderTransferAmountLoValidityProof:     &CiphertextValidityProof{},
+				SenderTransferAmountHiValidityProof:     &CiphertextValidityProof{},
+				RecipientTransferAmountLoValidityProof:  &CiphertextValidityProof{},
+				RecipientTransferAmountHiValidityProof:  &CiphertextValidityProof{},
+				RemainingBalanceRangeProof:              &RangeProof{},
+				RemainingBalanceEqualityProof:           &CiphertextCommitmentEqualityProof{},
+			},
+			wantErr: true,
+			errMsg:  "transfer amount lo equality proof is required",
+		},
+		{
+			name: "missing TransferAmountHiEqualityProof",
+			proofs: TransferProofs{
+				RemainingBalanceCommitmentValidityProof: &CiphertextValidityProof{},
+				SenderTransferAmountLoValidityProof:     &CiphertextValidityProof{},
+				SenderTransferAmountHiValidityProof:     &CiphertextValidityProof{},
+				RecipientTransferAmountLoValidityProof:  &CiphertextValidityProof{},
+				RecipientTransferAmountHiValidityProof:  &CiphertextValidityProof{},
+				RemainingBalanceRangeProof:              &RangeProof{},
+				RemainingBalanceEqualityProof:           &CiphertextCommitmentEqualityProof{},
+				TransferAmountLoEqualityProof:           &CiphertextCiphertextEqualityProof{},
+			},
+			wantErr: true,
+			errMsg:  "transfer amount hi equality proof is required",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			_, err := tt.proofs.FromProto()
+			if tt.wantErr {
+				require.Error(t, err)
+				require.Contains(t, err.Error(), tt.errMsg)
+			} else {
+				require.NoError(t, err)
+			}
+		})
+	}
+}