Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 6.0 Shift #3

Merged
merged 7 commits into from
Oct 28, 2019
Merged

Laravel 6.0 Shift #3

merged 7 commits into from
Oct 28, 2019

Conversation

sehinde-gb
Copy link
Owner

This pull request includes the changes for upgrading to Laravel 6.0. Feel free to commit any additional changes to the shift-20059 branch.

Before merging, you need to:

  • Checkout the shift-20059 branch
  • Review all pull request comments for additional changes
  • Update your dependencies for Laravel 6.0
  • Run composer update (if the scripts fail, add --no-scripts)
  • Thoroughly test your application (no tests?)

If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.

The Laravel framework adopts the PSR-2 coding style with some additions.
Laravel apps *should* adopt this coding style as well.

However, Shift allows you to customize the adopted coding style through
by using your [PHP CS Fixer][1] config within your project.

You may use [Shift's .php_cs][2] file as a base.

[1]: https://github.com/FriendsOfPHP/PHP-CS-Fixer
[2]: https://gist.github.com/laravel-shift/cab527923ed2a109dda047b97d53c200
Laravel recommends using the `Str` and `Arr` class methods directly instead of the respective helper functions. These helper functions are [deprecated in Laravel 5.8][1] and will be removed in a future version.

[1]: laravel/framework#26898
In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them so you can review the commit diff for
changes. Moving forward, you should use ENV variables or create a
separate config file to allow the core config files to remain
automatically upgradeable.
@sehinde-gb
Copy link
Owner Author

❌ Shift could not upgrade the following files since they differed from the default Laravel version. You will need to compare these files against the default Laravel 6 versions and merge any changes:

  • app/Http/Controllers/Auth/ResetPasswordController.php
  • app/Http/Kernel.php
  • resources/lang/en/validation.php

@sehinde-gb
Copy link
Owner Author

⚠️ Shift defaulted the following configuration files. This was done in the Default config files commit so you may easily review and backfill your customizations. If you have a lot of customizations, you may also undo this commit with git revert and upgrade these files manually.

  • config/mail.php
  • config/queue.php
  • config/services.php

@sehinde-gb
Copy link
Owner Author

ℹ️ Laravel 6.0 changed the default Redis client from predis to phpredis. You may keep using predis by setting REDIS_CLIENT=predis for your environment.

However, if possible, consider switching to phpredis to gain the performance of its PHP extension and avoid using the deprecated predis dependency which will be removed in Laravel 7.0.

@sehinde-gb
Copy link
Owner Author

ℹ️ Shift makes an effort to update your dependencies for Laravel 6.0. While many of the popular packages are reviewed, you may have to update additional packages or version constraints in order for your application to be compatible with Laravel 6.0. Watch dealing with dependencies for tips on handling package incompatibilities.

@sehinde-gb
Copy link
Owner Author

❌ Laravel 6.0 has a dependency for php of ^7.2. You have a modified dependency for php in your composer.json. You should review your dependency and ensure it meets the new version requirement.

@sehinde-gb
Copy link
Owner Author

❌ Shift detected your application has a development dependency for the laravel/dusk package. The recommended version for Laravel 6.0 is ^5.5. You should review your dependency and ensure it meets the new version requirement, as well as review their README for additional changes.

@sehinde-gb
Copy link
Owner Author

ℹ️ Laravel 6.0 made performance optimizations for integer key types. If you are using a string as your model's primary key, you may set the $keyType property on your model.

/**
 * The "type" of the primary key ID.
 *
 * @var string
 */
protected $keyType = 'string';

@sehinde-gb
Copy link
Owner Author

ℹ️ The mandrill and sparkpost mail drivers, as well as the rackspace storage driver were removed in Laravel 6.0. If you were using these drivers, you may adopt a community maintained package which provides the driver.

@sehinde-gb
Copy link
Owner Author

ℹ️ Previous versions of Laravel would retry jobs indefinitely. Beginning with Laravel 6.0, the php artisan queue:work now tries a job one time by default. If you want to force jobs to be tried indefinitely, you may pass the --tries=0 option.

@sehinde-gb
Copy link
Owner Author

🎉 Congratulations, you're now running the latest version of Laravel.

The following Shifts can ensure your app is fully upgraded and following the practices recommended by Laravel and the community:

  • Laravel Linter analyzes your codebase for potential opportunities to do things "The Laravel Way".
  • Laravel Fixer automates many of the suggestions found by the Linter and other Shifts.
  • Upgrade Checker ensures your application is fully upgraded by detecting any outdated code.

In addition, stay upgraded forever as well as run these Shifts by subscribing to one of the new Shifty Plans.

@sehinde-gb sehinde-gb merged commit 1b5bca4 into master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants