Skip to content

Commit

Permalink
fix: update readme to pass static test (Azure#3832)
Browse files Browse the repository at this point in the history
## Description

Fixes Azure#3829 

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|          |

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [x] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
  • Loading branch information
rahalan authored Dec 3, 2024
1 parent 063f984 commit d1157d8
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
11 changes: 10 additions & 1 deletion avm/res/compute/virtual-machine-scale-set/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ This module deploys a Virtual Machine Scale Set.
| :-- | :-- |
| `Microsoft.Authorization/locks` | [2020-05-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Authorization/2020-05-01/locks) |
| `Microsoft.Authorization/roleAssignments` | [2022-04-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Authorization/2022-04-01/roleAssignments) |
| `Microsoft.Compute/virtualMachineScaleSets` | [2023-09-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Compute/2023-09-01/virtualMachineScaleSets) |
| `Microsoft.Compute/virtualMachineScaleSets` | [2024-07-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Compute/2024-07-01/virtualMachineScaleSets) |
| `Microsoft.Compute/virtualMachineScaleSets/extensions` | [2023-09-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Compute/2023-09-01/virtualMachineScaleSets/extensions) |
| `Microsoft.Insights/diagnosticSettings` | [2021-05-01-preview](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Insights/2021-05-01-preview/diagnosticSettings) |

Expand Down Expand Up @@ -362,6 +362,7 @@ module virtualMachineScaleSet 'br/public:avm/res/compute/virtual-machine-scale-s
enabled: true
}
extensionMonitoringAgentConfig: {
autoUpgradeMinorVersion: true
enabled: true
}
extensionNetworkWatcherAgentConfig: {
Expand Down Expand Up @@ -572,6 +573,7 @@ module virtualMachineScaleSet 'br/public:avm/res/compute/virtual-machine-scale-s
},
"extensionMonitoringAgentConfig": {
"value": {
"autoUpgradeMinorVersion": true,
"enabled": true
}
},
Expand Down Expand Up @@ -768,6 +770,7 @@ param extensionDependencyAgentConfig = {
enabled: true
}
param extensionMonitoringAgentConfig = {
autoUpgradeMinorVersion: true
enabled: true
}
param extensionNetworkWatcherAgentConfig = {
Expand Down Expand Up @@ -893,6 +896,7 @@ module virtualMachineScaleSet 'br/public:avm/res/compute/virtual-machine-scale-s
]
disablePasswordAuthentication: true
extensionMonitoringAgentConfig: {
autoUpgradeMinorVersion: true
enabled: true
}
location: '<location>'
Expand Down Expand Up @@ -995,6 +999,7 @@ module virtualMachineScaleSet 'br/public:avm/res/compute/virtual-machine-scale-s
},
"extensionMonitoringAgentConfig": {
"value": {
"autoUpgradeMinorVersion": true,
"enabled": true
}
},
Expand Down Expand Up @@ -1079,6 +1084,7 @@ param dataDisks = [
]
param disablePasswordAuthentication = true
param extensionMonitoringAgentConfig = {
autoUpgradeMinorVersion: true
enabled: true
}
param location = '<location>'
Expand Down Expand Up @@ -1400,6 +1406,7 @@ module virtualMachineScaleSet 'br/public:avm/res/compute/virtual-machine-scale-s
}
}
extensionMonitoringAgentConfig: {
autoUpgradeMinorVersion: true
enabled: true
}
extensionNetworkWatcherAgentConfig: {
Expand Down Expand Up @@ -1604,6 +1611,7 @@ module virtualMachineScaleSet 'br/public:avm/res/compute/virtual-machine-scale-s
},
"extensionMonitoringAgentConfig": {
"value": {
"autoUpgradeMinorVersion": true,
"enabled": true
}
},
Expand Down Expand Up @@ -1794,6 +1802,7 @@ param extensionHealthConfig = {
}
}
param extensionMonitoringAgentConfig = {
autoUpgradeMinorVersion: true
enabled: true
}
param extensionNetworkWatcherAgentConfig = {
Expand Down
2 changes: 1 addition & 1 deletion avm/res/compute/virtual-machine-scale-set/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ resource avmTelemetry 'Microsoft.Resources/deployments@2024-03-01' = if (enableT
}
}

resource vmss 'Microsoft.Compute/virtualMachineScaleSets@2023-09-01' = {
resource vmss 'Microsoft.Compute/virtualMachineScaleSets@2024-07-01' = {
name: name
location: location
tags: tags
Expand Down
8 changes: 4 additions & 4 deletions avm/res/compute/virtual-machine-scale-set/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.31.92.45157",
"templateHash": "5570232042557896838"
"templateHash": "2848933356458236613"
},
"name": "Virtual Machine Scale Sets",
"description": "This module deploys a Virtual Machine Scale Set.",
Expand Down Expand Up @@ -932,7 +932,7 @@
},
"vmss": {
"type": "Microsoft.Compute/virtualMachineScaleSets",
"apiVersion": "2023-09-01",
"apiVersion": "2024-07-01",
"name": "[parameters('name')]",
"location": "[parameters('location')]",
"tags": "[parameters('tags')]",
Expand Down Expand Up @@ -2518,14 +2518,14 @@
"metadata": {
"description": "The principal ID of the system assigned identity."
},
"value": "[coalesce(tryGet(tryGet(reference('vmss', '2023-09-01', 'full'), 'identity'), 'principalId'), '')]"
"value": "[coalesce(tryGet(tryGet(reference('vmss', '2024-07-01', 'full'), 'identity'), 'principalId'), '')]"
},
"location": {
"type": "string",
"metadata": {
"description": "The location the resource was deployed into."
},
"value": "[reference('vmss', '2023-09-01', 'full').location]"
"value": "[reference('vmss', '2024-07-01', 'full').location]"
}
}
}

0 comments on commit d1157d8

Please sign in to comment.