Merge pull request #20 from davisjam/FixUndef

handle undefined string
segmentio · Mar 26, 2018 · a524d7f · a524d7f
2 parents 8585fac + b33cac4
commit a524d7f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -24,6 +24,10 @@ var nonLocalhostDomainRE = /^[^\s\.]+\.\S{2,}$/;
  */
 
 function isUrl(string){
+  if (typeof string !== 'string') {
+    return false;
+  }
+
   var match = string.match(protocolAndDomainRE);
   if (!match) {
     return false;

diff --git a/test/index.js b/test/index.js
@@ -118,6 +118,22 @@ describe('is-url', function () {
     it('google.com', function () {
       assert(!url('google.com'));
     });
+
+    it('empty', function () {
+      assert(!url(''));
+    });
+
+    it('undef', function () {
+      assert(!url(undefined));
+    });
+
+    it('object', function () {
+      assert(!url({}));
+    });
+
+    it('re', function () {
+      assert(!url(/abc/));
+    });
   });
 
   describe('redos', function () {