Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

fix(preferences): uniformize events import #287

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jean9696
Copy link

@jean9696 jean9696 commented Nov 15, 2022

Hi,

I found out that the import of 'events' is not uniformized. As I need to make an alias for events (which is a node module), I think it can be nice to use only the default import

@nd4p90x
Copy link
Collaborator

nd4p90x commented Nov 18, 2022

@jean9696 Can you merge in the latest so we can merge this PR? Thank you.

@jean9696
Copy link
Author

@nd4p90x should be fine now

@nd4p90x
Copy link
Collaborator

nd4p90x commented Jan 11, 2023

@jean9696 Looks like we are out of sync again. Sorry for the delay, I promise we will get to it as soon as you update the branch.

Thanks,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants