This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
🐛 Bug FIX: Updated "types" directory #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no `src` directory under the `types` directory, so the declarations were failing. This PR points to the correct file. Related to [segmentio#111](segmentio#111). kudos to my colleague @mrseanbaines who noticed the path was wrong.
|
Perfect timing, just as I was trying to build a customized segment cookie consent in React / TypeScript. 👍 Any tips on how I can get this to work now? I'm trying to create my own definitions file Apparently the following worked for me: declare module "@segment/consent-manager" {
export * from "@segment/consent-manager/types/index";
} |
|
Is there an ETA for when this will get merged? Looks like it's been ready to go for over 9 months now. |
|
@mantissa7 @kilinkis @ItsWendell Hi everyone! Sorry for the late response. Segment team. |
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no
srcdirectory under thetypesdirectory, so the declarations were failing.This PR points to the correct file.
Related to #111.
kudos to my colleague @mrseanbaines who noticed the path was wrong.