This repository has been archived by the owner on May 18, 2021. It is now read-only.
Bugfix to migrate Factor U2F to WebAuthn. #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallbrekka
force-pushed
the
bugfix/marshallbrekka/1.x-webauthn-support
branch
from
2b34586
to
df6f1cf
Compare
marshallbrekka
force-pushed
the
bugfix/marshallbrekka/1.x-webauthn-support
branch
from
df6f1cf
to
a31f128
Compare
|
@marshallbrekka Thanks! Regarding the |
Add additional C files.
|
@nickatsegment updated |
nickatsegment
approved these changes
Jan 20, 2020
Merged
|
Has anyone confirmed this works? I created a test okta org with WebAuthn enabled, and an aws account with MFA enabled every sign on, and I cannot get it to work, fails on getting SAML creds. I might have messed something up in configuring a test org – it's a ton of fiddly work. But I can confirm if I disable the MFA requirement then I am able to run my commands. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #248 against the 1.x code base.
#276 Applies the same patch to the 2.x code.
I had to use https://github.com/goware/modvendor to vendor the required C files for the hid library, since
go moddoes not include them golang/go#26366.This is breaking the circleci verification of the mod vendor.
Would appreciate some suggestions for how the project would prefer to resolve that issue.