Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #344 fix tests #425

Merged
merged 66 commits into from
Feb 26, 2024

Conversation

nd4p90x
Copy link
Collaborator

@nd4p90x nd4p90x commented Jan 31, 2024

Update the github actions to include loading of application requirements file and execute tests for each version

@nd4p90x
Copy link
Collaborator Author

nd4p90x commented Jan 31, 2024

@MichaelGHSeg Please review and confirm test action is completing after update. Thank you.

@MichaelGHSeg
Copy link
Contributor

Looks like it's only running the 8 tests in segment/analytics/test/init.py
I feel like the easiest way to do this might be to move the contents of init.py (without the hack to run other test files that doesn't seem to work) to a differently named file and make init.py blank. Some things I read said a blank init would have it run everything.

@nd4p90x
Copy link
Collaborator Author

nd4p90x commented Feb 1, 2024

@MichaelGHSeg I reformatted the test suite to conform to python 3 requirements. All tests appear to be executing as expected, however, we are receiving some errors on the oath test regarding URL and possibly other issues related to the written tests. Would you like to handle the oath test issues?

@MichaelGHSeg
Copy link
Contributor

I'll take a look

@MichaelGHSeg
Copy link
Contributor

OAuth is working as intended, the tests that make sure exceptions are handled are just noisy.

The utility tests seem to have what I'm guessing is a python3 problem where datetimes, exceptions, and functions aren't serializable when they once were? It ends up just leaving them out of the output and comparison datasets so it still passes, but we could clean that up.

@nd4p90x
Copy link
Collaborator Author

nd4p90x commented Feb 21, 2024

@MichaelGHSeg Removal of that requirement you suggested worked, ready to move forward.

Thanks,

@MichaelGHSeg MichaelGHSeg merged commit acbaa9f into segmentio:master Feb 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants