-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #344 fix tests #425
Issue #344 fix tests #425
Conversation
…Five/analytics-python into Issue-segmentio#344-Fix-Tests # Conflicts: # README.md
@MichaelGHSeg Please review and confirm test action is completing after update. Thank you. |
Looks like it's only running the 8 tests in segment/analytics/test/init.py |
@MichaelGHSeg I reformatted the test suite to conform to python 3 requirements. All tests appear to be executing as expected, however, we are receiving some errors on the oath test regarding URL and possibly other issues related to the written tests. Would you like to handle the oath test issues? |
I'll take a look |
OAuth is working as intended, the tests that make sure exceptions are handled are just noisy. The utility tests seem to have what I'm guessing is a python3 problem where datetimes, exceptions, and functions aren't serializable when they once were? It ends up just leaving them out of the output and comparison datasets so it still passes, but we could clean that up. |
@MichaelGHSeg Removal of that requirement you suggested worked, ready to move forward. Thanks, |
Update the github actions to include loading of application requirements file and execute tests for each version