Stringify userId and anonymousId #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: https://segment.atlassian.net/browse/LIB-27 Our API truncates bignum values. This is problematic because this library has historically accepted Numbers as userIds and anonymousIds. TTo workaround the truncation, this library needs to stringify userId and anonymousId on the client. The test cases are numbers that will be truncated in Node, e.g. `node -e "console.log(157963456373623802 + 1)"`.
|
(let me know if this can be written in a better way in python) |
tejasmanohar
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://segment.atlassian.net/browse/LIB-27
Our API truncates bignum values. This is problematic because this library has historically accepted Numbers as userIds and anonymousIds. TTo workaround the truncation, this library needs to stringify userId and anonymousId on the client.
The test cases are numbers that will be truncated in Node, e.g.
node -e "console.log(157963456373623802 + 1)".