Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update consent-wrapper-onetrust target #962

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Update consent-wrapper-onetrust target #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2567e3
update consent
silesky Oct 2, 2023
17c9f95
wip
silesky Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tall-colts-breathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@segment/analytics-consent-wrapper-onetrust': patch
---

Change tsconfig compile target from ESNext->ES2020
3 changes: 2 additions & 1 deletion packages/consent/consent-tools/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"target": "ES2020", // don't down-compile *too much* -- if users are using webpack, they can always transpile this library themselves
"lib": ["ES2020", "DOM", "DOM.Iterable"], // assume that consumers will be polyfilling at least down to es2020
"moduleResolution": "node",
"resolveJsonModule": true
"resolveJsonModule": true,
"isolatedModules": true // ensure we are friendly to build systems
}
}
2 changes: 1 addition & 1 deletion packages/consent/consent-wrapper-onetrust/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"exclude": ["node_modules", "dist"],
"compilerOptions": {
"module": "ESNext", // es6 modules
"target": "ESNext", // assume that consumers will be using webpack, so don't down-compile
"target": "ES2020", // don't down-compile *too much* -- if users are using webpack, they can always transpile this library themselves
"lib": ["ES2020", "DOM", "DOM.Iterable"], // assume that consumers will be polyfilling at least down to es2020
"moduleResolution": "node",
"isolatedModules": true // ensure we are friendly to build systems
Expand Down