Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support screen events on AJS on Segment Destination #896

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

oscb
Copy link
Contributor

@oscb oscb commented Jul 13, 2023

Adds screen support to Segment's destination.

Previously screen events where captured and processed correctly but not sent to Segment.

Added tests.

[✔︎] I've included a changeset (psst. run yarn changeset. Read about changesets here).

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023

🦋 Changeset detected

Latest commit: 80c39ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@silesky silesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oscb oscb merged commit 48ce3ec into master Jul 14, 2023
@oscb oscb deleted the oscb/screen branch July 14, 2023 16:56
@github-actions github-actions bot mentioned this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants