[LIBWEB-1353] Fix cookie write error #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 807d896 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zikaari
force-pushed
the
cookie_error_fix
branch
3 times, most recently
from
c9b2dcb to
cdc8606
Compare
zikaari
force-pushed
the
cookie_error_fix
branch
from
cdc8606 to
f33fc25
Compare
oscb
reviewed
Jul 13, 2023
| cookieEnabled = document.cookie.includes('ajs:cookies') | ||
| jar.remove('ajs:cookies') | ||
| try { | ||
| jar.set('ajs_cookies', 'test') |
There was a problem hiding this comment.
nit: for quick reuse putting ajs_cookies as a const AJS_COOKIE_AVAILABILITY_KEY or similar.
I would also suggest renaming it to ajs_cookies_check or something to highight that it is only an availability check cookie.
There was a problem hiding this comment.
good point! Also, all of these strings get repeated in the bundle -- using a constant saves bytes!
oscb
approved these changes
Jul 13, 2023
chrisradek
approved these changes
Jul 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analytics would fail fatally if cookies are made inaccessible by overriding the cookie getter/setter by a piece of code. This patch adds resilience against such a case.