Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updateCDNSettings() option #870

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Add updateCDNSettings() option #870

merged 1 commit into from
Jun 7, 2023

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Jun 5, 2023

It's very little code and doesn't expose any interfaces that we weren't exposing before. Also, any of our customers who were importing "fetchLegacySettings" could just use this API now.

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2023

🦋 Changeset detected

Latest commit: 6b16cba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky requested a review from oscb June 5, 2023 20:44
@silesky silesky changed the title Add cdn settings option Add updateCDNSettings() option Jun 5, 2023
@silesky silesky requested a review from chrisradek June 5, 2023 20:50
Copy link
Contributor

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@silesky silesky force-pushed the add-cdn-settings-option branch from 82ecb30 to 1d54a70 Compare June 7, 2023 19:13
@silesky silesky force-pushed the add-cdn-settings-option branch from 1d54a70 to 6b16cba Compare June 7, 2023 19:14
@silesky silesky merged commit f23f3be into master Jun 7, 2023
@silesky silesky deleted the add-cdn-settings-option branch June 7, 2023 19:18
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants