Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix staging-only bug where integrations URL would not respect CDN URL overrides #800

Merged

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Feb 24, 2023

Fixes a bug where staging CDNUrl is not properly overridden.

repro: https://sethsilesky.com/ajs-cd.html

image

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2023

🦋 Changeset detected

Latest commit: 9816acd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky requested a review from pooyaj February 24, 2023 19:46
@silesky silesky requested a review from chrisradek February 24, 2023 19:48
@silesky silesky force-pushed the fix-staging-bug-where-integrations-were-fetched-from-wrong-url branch from 379fce0 to 9816acd Compare February 24, 2023 19:56
@silesky silesky changed the title fix stage bug where integrations were fetched from wrong url Fix staging-only bug where integrations URL would not respect CDN URL overrides Feb 24, 2023
@silesky silesky requested a review from zikaari February 24, 2023 19:59
Copy link
Contributor

@pooyaj pooyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@silesky silesky merged commit fe98d5e into master Feb 24, 2023
@silesky silesky deleted the fix-staging-bug-where-integrations-were-fetched-from-wrong-url branch February 24, 2023 21:51
@github-actions github-actions bot mentioned this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants