Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support typescript "NodeNext" module resolution #776

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix: support typescript "NodeNext" module resolution #776

merged 1 commit into from
Jan 30, 2023

Conversation

thomasskk
Copy link
Contributor

Currently typescript cant resolve types when { moduleResolution: "NodeNext" } is in tsconfig.

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2023

⚠️ No Changeset found

Latest commit: 2b23518

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@silesky silesky self-requested a review January 30, 2023 18:27
@silesky
Copy link
Contributor

silesky commented Jan 30, 2023 •
edited
Loading

@thomasskk --
Thanks for the contribution. Published in: 0.0.1-beta.17.

@silesky silesky merged commit 8285b6e into segmentio:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silesky silesky silesky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasskk @silesky