Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: export Param types #767

Merged
merged 2 commits into from
Jan 11, 2023
Merged

node: export Param types #767

merged 2 commits into from
Jan 11, 2023

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Jan 11, 2023

Addresses #766

@changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1fb20ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@silesky silesky force-pushed the export-params-types branch from 4173c1c to 87e9160 Compare January 11, 2023 19:05
@silesky silesky changed the title node: export param types node: export Param types Jan 11, 2023
@silesky silesky force-pushed the export-params-types branch 2 times, most recently from bf0d6b7 to be88057 Compare January 11, 2023 19:25
@silesky silesky force-pushed the export-params-types branch from be88057 to 1fb20ad Compare January 11, 2023 19:44
mpalmerlee
mpalmerlee reviewed Jan 11, 2023
View reviewed changes
packages/node/src/index.ts
AliasParams,
GroupParams,
PageParams,
} from './app/types'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for the quick change 😍 🙌

@silesky silesky merged commit a1cfb93 into master Jan 11, 2023
@silesky silesky deleted the export-params-types branch January 11, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpalmerlee mpalmerlee mpalmerlee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silesky @mpalmerlee