Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: add context, timestamp, integration options #694

Merged
merged 1 commit into from
Nov 29, 2022
Merged

node: add context, timestamp, integration options #694

merged 1 commit into from
Nov 29, 2022

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Nov 23, 2022 •
edited
Loading

Adding options to top level of events to make consistent with old SDK (and flat is better!).

  • context
  • integrations
  • timestamp

@changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: e5aa3ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@silesky silesky requested a review from chrisradek November 24, 2022 16:19
@silesky silesky changed the title Add additional fields like context timestamp to top level [goes in after cb PR] node: add additional fields like context timestamp to top level [goes in after cb PR] Nov 27, 2022
@silesky silesky marked this pull request as ready for review November 27, 2022 23:19
@silesky silesky force-pushed the master branch 2 times, most recently from da031b5 to 275d5a3 Compare November 27, 2022 23:54
@silesky silesky force-pushed the add-additional-fields-like-context-timestamp-to-top-level branch from 91fe0a2 to e5aa3ea Compare November 28, 2022 20:03
@silesky silesky changed the title node: add additional fields like context timestamp to top level [goes in after cb PR] node: add context, timestamp, integration options Nov 28, 2022
@silesky silesky requested a review from a team November 28, 2022 22:37
arielsilvestri
arielsilvestri approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@arielsilvestri arielsilvestri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@silesky silesky merged commit 03e6383 into master Nov 29, 2022
@silesky silesky deleted the add-additional-fields-like-context-timestamp-to-top-level branch November 29, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielsilvestri arielsilvestri arielsilvestri approved these changes

@chrisradek chrisradek Awaiting requested review from chrisradek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silesky @arielsilvestri