browser: refactor/remove asPromise

[silesky]

This asPromise method seems to add unneccessary complexity both in the way it's used and by virtue of its existence. If there's a galaxy brain reason for why we'd do this, I can't find it.

A util method that's just an alias to Promise.resolve?... like whyyyyy 😄 And there are actual unit tests for this method?

[changeset-bot]

⚠️ No Changeset found

Latest commit: 04bf2c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[silesky]

I assume that the original intention to use await asPromise here was because MiddlewareFunction and SourceMiddleware could return a Promise -- and maybe whoever wrote this originally didn't realize that void | Promise<void> is a valid return type -- or that there's no requirement to "normalize" all values to a promise in order to await -- that you can just as easily await a regular value as a promise (await 123=== await Promise.resolve(123)).

[chrisradek]

Sweet, love removing code!