Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minimum node support on analytics-node to 14.x #671

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Nov 12, 2022

Node 12 LTS has been at complete end-of-life for 6 months, we should not include any official support for it. This change also allows us to compile to ES2020 (smaller package and allows us to use actual JS private fields / methods if we want).

We already use node 14 for buildkite runner, so no change needed.

image

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2022

⚠️ No Changeset found

Latest commit: d757a70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@silesky silesky requested a review from chrisradek November 12, 2022 19:54
@silesky silesky force-pushed the analytics-node-should-use-14 branch from 9d842d9 to ea478d3 Compare November 12, 2022 19:55
@silesky silesky changed the title make analytics-node require node 14 Upgrade minimum node support on analytics-node to 14.x Nov 12, 2022
@silesky silesky requested a review from a team November 14, 2022 17:49
@silesky silesky merged commit 67c92cb into master Nov 14, 2022
@silesky silesky deleted the analytics-node-should-use-14 branch November 14, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants