Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message when sending metrics fails #582

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

chrisradek
Copy link
Contributor

This PR updates the error message logged when sending client-side performance metrics to segment fails.
See https://segment.com/docs/connections/sources/catalog/libraries/website/javascript/troubleshooting/#why-do-i-see-a-network-request-to-m for background info on client-side performance metrics.

These metrics do not impact customer event delivery, but can cause confusion when showing up on platforms like Sentry when an error occurs. This provides a way to filter out these messages by the new error message preceding the error.

[x] I've included a changeset (psst. run yarn changeset. Read about changesets here).

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2022

🦋 Changeset detected

Latest commit: 9474a25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@silesky silesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chrisradek chrisradek merged commit ebafece into master Aug 17, 2022
@chrisradek chrisradek deleted the metric-error-prefix branch August 17, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants