Improved error message logging in console #573
Conversation
🦋 Changeset detectedLatest commit: 9fb8918 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -26,6 +26,8 @@ const cdnResponse: LegacySettings = { | |||
|
|
|||
| const fetchSettings = Promise.resolve({ | |||
| json: () => Promise.resolve(cdnResponse), | |||
| text: () => Promise.resolve('text'), | |||
There was a problem hiding this comment.
Ugh: these naive http mocks are brittle -- I've been using https://github.com/segmentio/analytics-next/blob/create-rc-of-analytics-node/packages/browser/src/test-helpers/factories.ts in new tests and have refactored some of the old tests to use them, but they're still all over.
| @@ -83,9 +83,16 @@ export function loadLegacySettings( | |||
| const baseUrl = cdnURL ?? getCDN() | |||
|
|
|||
| return fetch(`${baseUrl}/v1/projects/${writeKey}/settings`) | |||
| .then((res) => res.json()) | |||
| .then((res) => { | |||
There was a problem hiding this comment.
Looks good! Can we get some client tests?
|
We may need to update all the tests that use mock fetch to use more robust HTTP mock, since it's checking for Another reason why using nock / msw is in general a recommended approach over mocking fetch. |
packages/browser/src/browser/__tests__/analytics-pre-init.integration.test.ts
Outdated
Show resolved
Hide resolved
Adds a console error with the error status text from the API explaining to users what went wrong with the
settingscall.
.