Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope signal buffer to session #1190

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Nov 14, 2024

  • Clear signal buffer at start of new session for indexDB.
  • Prune signalBuffer to maxBufferSize on new session (if different)
  • Add sessionStorage storageType setting, since, with indexDB, the storage of signals until the next session may constitute a security risk.
  • Fix deletion concurrency bug

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: c70e737

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-signals Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky requested a review from MichaelGHSeg November 14, 2024 21:23
@silesky silesky force-pushed the scope-signal-buffer-to-session branch from 9273ea3 to 57a68c7 Compare November 14, 2024 21:24
alanjcharles
alanjcharles previously approved these changes Nov 14, 2024
@silesky silesky merged commit 46e8819 into master Nov 18, 2024
7 checks passed
@silesky silesky deleted the scope-signal-buffer-to-session branch November 18, 2024 17:18
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants