Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signals analytics runtime #1168

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Signals analytics runtime #1168

merged 4 commits into from
Oct 30, 2024

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Oct 10, 2024

  • add '@segment/analytics-signals-runtime' package and consume it from web
  • speed up tests

Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: 1448626

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@segment/analytics-signals-runtime Major
@segment/analytics-signals Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky force-pushed the signals-analytics-runtime branch from 1ca10b5 to 1448626 Compare October 30, 2024 18:53
@silesky silesky marked this pull request as ready for review October 30, 2024 18:53
@silesky silesky requested a review from danieljackins October 30, 2024 18:54
Copy link
Contributor

@danieljackins danieljackins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -0,0 +1,10 @@
# @segment/analytics-signals-runtime
Encapsults Signals runtime functionality, in order to share logic between the signals plugins for browser and mobile.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@silesky silesky merged commit ba2f2b1 into master Oct 30, 2024
7 checks passed
@silesky silesky deleted the signals-analytics-runtime branch October 30, 2024 21:14
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants