Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug experience #1125

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Fix debug experience #1125

merged 2 commits into from
Aug 15, 2024

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Aug 14, 2024

There was previous no way to actually debug ajs-destinations because of hash mismatches locally. This has been an issue serveral times for people who’ve had to debug important destination related code. The workaround has been to use chrome’s local overrides and paste code, which extremely manual and not intutitive.

image

This fixes that issue:

image

@silesky silesky requested a review from danieljackins August 14, 2024 15:21
Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: 286bc43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky changed the title fix debug experience Fix debug experience Aug 14, 2024
bsneed
bsneed previously approved these changes Aug 14, 2024
danieljackins
danieljackins previously approved these changes Aug 14, 2024
Copy link
Contributor

@danieljackins danieljackins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg 🔥

@silesky silesky dismissed stale reviews from danieljackins and bsneed via 81200fb August 14, 2024 19:27
@silesky silesky force-pushed the fix-debug-experience branch from 63273d5 to 81200fb Compare August 14, 2024 19:27
@silesky silesky requested a review from danieljackins August 14, 2024 20:06
@silesky silesky merged commit 7aed96e into master Aug 15, 2024
5 checks passed
@silesky silesky deleted the fix-debug-experience branch August 15, 2024 17:50
@github-actions github-actions bot mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants