Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow collecting signals even if edge function is not defined. #1112

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Jul 17, 2024

We do not want to throw an error if there is no edge function defined, as a user may have not saved a processSignal function yet.

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: 24afb22

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-signals Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky requested a review from alanjcharles July 17, 2024 21:34
@silesky silesky requested a review from MichaelGHSeg July 17, 2024 21:39
@silesky silesky merged commit 1f68f0e into master Jul 18, 2024
5 checks passed
@silesky silesky deleted the fix-onboarding-error branch July 18, 2024 16:49
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants