Fix npm install error because of node-gyp #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3786f9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
force-pushed
the
fix-npm-install-tsub-issue
branch
from
1ff6e3f to
2b0e1b5
Compare
silesky
changed the title
bsneed
previously approved these changes
Jul 12, 2024
silesky
force-pushed
the
fix-npm-install-tsub-issue
branch
from
df08d92 to
3786f9e
Compare
alanjcharles
approved these changes
Jul 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes dependency on node-gyp by vendoring the tsub library. The tsub library has an 'unclear' ownership and changes infrequently, so this is a safe way to address this issues.
No dependency on stdlib means that this dramatically reduces the size of the analytics.js dependency tree.
addresses:
#1087
#1082