Support adding middleware to every device mode destination #1053
Conversation
🦋 Changeset detectedLatest commit: 286fb8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -878,6 +878,90 @@ describe('addDestinationMiddleware', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| it('drops events if next is never called', async () => { | |||
There was a problem hiding this comment.
These scenarios were not affected, but there didn't seem to be any explicit test coverage -- and they are relevant to what we're trying to do with consent. Anyway, threw those addition tests in -- since the docs don't even mention that you can call next with "null" to drop events.
| @@ -226,7 +226,6 @@ export class LegacyDestination implements DestinationPlugin { | |||
| type: 'Dropped by plan', | |||
| }) | |||
| ) | |||
| return ctx | |||
There was a problem hiding this comment.
This is ok to remove because our event queue doesn't do anything with the returned ctx?
There was a problem hiding this comment.
It's dead code, since the ctx.cancel above throws an error (it's return type is never).
My editor kept auto-removing them for some reason, so I just kept it in.
| if ( | ||
| routing.length && | ||
| routingMiddleware && | ||
| plugin.type === 'destination' |
There was a problem hiding this comment.
Ah cool - so we were actually doing this check twice because addMiddleware also checks this
Add
*glob support.[x] I've included a changeset