fix: fixes buffering for legacy destinations (#1067)

segmentio · Apr 12, 2024 · e3f3bee · e3f3bee
1 parent fd09fbc
commit e3f3bee
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/three-turkeys-talk.md b/.changeset/three-turkeys-talk.md
@@ -0,0 +1,5 @@
+---
+'@segment/analytics-next': patch
+---
+
+fix: fixes buffering for legacy destinations
diff --git a/packages/browser/src/plugins/ajs-destination/index.ts b/packages/browser/src/plugins/ajs-destination/index.ts
@@ -192,7 +192,7 @@ export class LegacyDestination implements InternalPluginWithAddMiddleware {
     return (
       // page events can't be buffered because of destinations that automatically add page views
       ctx.event.type !== 'page' &&
-      (isOffline() || this._ready === false || this._initialized === false)
+      (isOffline() || this._ready !== true || this._initialized !== true)
     )
   }
 
@@ -313,6 +313,11 @@ export class LegacyDestination implements InternalPluginWithAddMiddleware {
 
     // eslint-disable-next-line @typescript-eslint/no-misused-promises
     setTimeout(async () => {
+      if (isOffline() || this._ready !== true || this._initialized !== true) {
+        this.scheduleFlush()
+        return
+      }
+
       this.flushing = true
       this.buffer = await flushQueue(this, this.buffer)
       this.flushing = false