Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build of the Swift Package with Xcode 12.5 beta 1 #983

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Fix the build of the Swift Package with Xcode 12.5 beta 1 #983

merged 1 commit into from
Feb 1, 2021

Conversation

layoutSubviews
Copy link
Contributor

What does this PR do?

Fix a build failure with the newly released Xcode 12.5 beta 1

Where should the reviewer start?

Try to build the Swift Package with Xcode 12.5 beta 1

How should this be manually tested?

Build.

Any background context you want to provide?

Xcode 12.5 beta 1 was released today, and introduces a new error when a #if statement is used with an undefined variable: "error: 'TARGET_OS_IPHONE' is not defined, evaluates to 0". This affects a single file, SEGIntegrationsManager.m.

Questions:

  • Does the docs need an update?
    No.
  • Are there any security concerns?
    No.
  • Do we need to update engineering / success?
    No.

@bsneed
Copy link
Contributor

bsneed commented Feb 1, 2021

thanks @layoutSubviews !

@bsneed bsneed merged commit 2cb9021 into segmentio:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants