Bsneed/version fixes #966
Merged
Bsneed/version fixes #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migs647
force-pushed
the
bsneed/version-fixes
branch
from
679a693 to
7c605f8
Compare
bsneed
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a number of inconsistencies with supported versions
Where should the reviewer start?
Test every platform and every version starting with Mac OS X 10.0
How should this be manually tested?
See above
Any background context you want to provide?
Cocoapods had issues when Analytics was linked as a 64bit library (iOS 11) with a 32 library (iOS 10). Mac OS would not work under building from source unless it was 10.13 for some, but would for swift package manager.
What are the relevant tickets?
https://segment.atlassian.net/browse/LIBMOBILE-211
https://segment.atlassian.net/browse/LIBMOBILE-214
https://segment.atlassian.net/browse/LIBMOBILE-212
https://segment.atlassian.net/browse/LIBMOBILE-222
Screenshots or screencasts (if UI/UX change)
Questions: