Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBMOBILE-149] Fixed double device payload #931

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

migs647
Copy link
Contributor

@migs647 migs647 commented Aug 18, 2020

What does this PR do?
Fixes an issue where device was in the payload twice.

Where should the reviewer start?
Look at version 4.0.4 vs this PR. 4.0.4 contained the issue, 4.0.3 did not. Compare SEGUtil

How should this be manually tested?
Run to see the payload, verify device isn't doubled up.

Any background context you want to provide?

What are the relevant tickets?
LIBMOBILE-149

Screenshots or screencasts (if UI/UX change)

Questions:

  • Does the docs need an update?
  • Are there any security concerns?
  • Do we need to update engineering / success?

@codecov-commenter
Copy link

Codecov Report

Merging #931 into master will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
- Coverage   86.13%   86.00%   -0.13%     
==========================================
  Files          57       57              
  Lines        3360     3365       +5     
==========================================
  Hits         2894     2894              
- Misses        466      471       +5     

@migs647 migs647 merged commit 2630a2b into master Aug 19, 2020
@migs647 migs647 deleted the LIBMOBILE-149-Double-Device branch October 27, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants