1-line change that fixes a warning in Xcode #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #815 +/- ##
==========================================
- Coverage 86.85% 86.81% -0.04%
==========================================
Files 52 52
Lines 2792 2792
==========================================
- Hits 2425 2424 -1
- Misses 367 368 +1 |
|
What is the warning that this fixes? |
|
|
cool, LGTM! cc @fathyb |
fathyb
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modifies one line of code to remove a warning from Xcode.
Where should the reviewer start?
From the top. There's only one line that changed (added 8 characters).
How should this be manually tested?
This change is purely syntactical and functionality will not be impacted.
Questions: