Update topViewController to handle UITabBarController #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated seg_topViewController:(UIViewController *) rootViewController to handle the case where the root view controller is a UITabBarController and not necessarily a UINavigationController. As our rootViewController was a subclass UITabBarController every auto-tracked event came back as Optimity.Main (for MainViewController)
|
hey @SBourgon thanks! could you add a test case? |
|
cc @migs647 |
|
This was indirectly fixed with PR: #899 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I did check to see about merging against dev, but there is no dev branch currently)
What does this PR do?
Updated seg_topViewController:(UIViewController *) rootViewController to handle the case where the root view controller is a UITabBarController and not only a UINavigationController.
Where should the reviewer start?
Auto-tracked events are on with UITabBarController as rootViewController
How should this be manually tested?
Any background context you want to provide?
As our rootViewController was a subclass UITabBarController every auto-tracked event came back as Optimity.Main (for MainViewController.swift)
What are the relevant tickets?