Remove -beta suffix from CFBundleShortVersionString #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the framework to be used in projects submitted to the App Store. Closes segmentio#794
|
Alternatively, releasing 3.7.0 will fix #794 but that's beyond the scope of what I can submit a PR for 😅 |
fathyb
approved these changes
Oct 22, 2018
Serheo
pushed a commit
to fubotv/analytics-ios
that referenced
this pull request
Aug 15, 2019
**What does this PR do?** This allows for the framework to be used in Swift 4 projects who consume this framework from Carthage, to be submitted to the App Store. Closes segmentio#794 **Where should the reviewer start?** By reading segmentio#794 **How should this be manually tested?** Create a project with Swift 4, consume this framework with Carthage, and then submit it to the App Store 😅 **Any background context you want to provide?** segmentio#794 **What are the relevant tickets?** segmentio#794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This allows for the framework to be used in Swift 4 projects who consume this framework from Carthage, to be submitted to the App Store.
Closes #794
Where should the reviewer start?
By reading #794
How should this be manually tested?
Create a project with Swift 4, consume this framework with Carthage, and then submit it to the App Store 😅
Any background context you want to provide?
#794
What are the relevant tickets?
#794