Declare framework dependencies in podspec

[jgavris]

Users may want to build the pod with Clang modules disabled using -fno-modules / CLANG_ENABLE_MODULES=NO because they are using ccache which doesn't support -fmodules. When modules are disabled, auto-linking of framework modules is also disabled, so these dependencies need to be expressed explicitly.

What does this PR do?

Declares all the frameworks the pod depends on explicitly in the podspec, so that users may disable 'Clang Modules' in order to build the Objective-C code using ccache for faster builds. When CLANG_ENABLE_MODULES is off, automatic framework linking is also implicitly turned off, so without this declaration the pod no longer links.

Where should the reviewer start?

Review that all frameworks listed are used in the pod.

How should this be manually tested?

Perform bundle exec pod install of this podspec and ensure the pod still builds in the target.

Questions:

• Does the docs need an update?

No.

• Are there any security concerns?

No, these are all Apple provided iOS frameworks.

• Do we need to update engineering / success?

No.

@segmentio/gateway

[codecov-io]

Codecov Report

Merging #773 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
+ Coverage   78.66%   78.73%   +0.06%     
==========================================
  Files          39       39              
  Lines        1467     1467              
==========================================
+ Hits         1154     1155       +1     
+ Misses        313      312       -1

[f2prateek]

@jgavris thanks! I had a question - how did you figure out which frameworks to add? Was it manual, or can we use a tool to do this?

I'll let @fathyb review some of the details as well, but

[jgavris]

I actually just iteratively compiled the project with CLANG_ENABLE_MODULES=NO in the pod target and looked at which frameworks provided the missing symbols.

You could also do something like

λ grep -hr "import <" . | sort -n | uniq
grep: ./.clang-format: No such file or directory
#import <AdSupport/ASIdentifierManager.h>
#import <Analytics/Analytics.h>
#import <Analytics/NSData+SEGGZIP.h>
#import <Analytics/SEGAES256Crypto.h>
#import <Analytics/SEGAnalytics.h>
#import <Analytics/SEGAnalyticsUtils.h>
#import <Analytics/SEGFileStorage.h>
#import <Analytics/SEGIntegrationsManager.h>
#import <Analytics/SEGSerializableValue.h>
#import <Analytics/SEGStoreKitTracker.h>
#import <Analytics/SEGUserDefaultsStorage.h>
#import <Analytics/UIViewController+SEGScreen.h>
#import <CommonCrypto/CommonCryptor.h>
#import <CommonCrypto/CommonKeyDerivation.h>
#import <CoreTelephony/CTCarrier.h>
#import <CoreTelephony/CTTelephonyNetworkInfo.h>
#import <Foundation/Foundation.h>
#import <StoreKit/StoreKit.h>
#import <SystemConfiguration/SystemConfiguration.h>
#import <UIKit/UIKit.h>
#import <arpa/inet.h>
#import <dlfcn.h>
#import <ifaddrs.h>
#import <netdb.h>
#import <netinet/in.h>
#import <netinet6/in6.h>
#import <objc/runtime.h>
#import <sys/socket.h>
#import <zlib.h>

[f2prateek]

Thanks - this makes it much easier to verify if we missed something.

[fathyb]

LGTM 👍
I added a branch on test-apps to test this https://github.com/segmentio/analytics-test-apps/tree/test/no-auto-link