Renames GZIP category to prevent collisions #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
=========================================
+ Coverage 86.17% 87.77% +1.6%
=========================================
Files 36 36
Lines 2582 2552 -30
Branches 175 177 +2
=========================================
+ Hits 2225 2240 +15
+ Misses 351 307 -44
+ Partials 6 5 -1 |
|
Thank you @gustavosaume ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Renames GZIP category to prevent collisions
Any background context you want to provide?
A naming collision happens when the Analytics library is used in a project that also imports the GZIP library as a pod.
What are the relevant tickets?
#703
Questions:
@segmentio/gateway