Send disabled events to Segment. #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #724 +/- ##
=========================================
+ Coverage 71.9% 71.94% +0.03%
=========================================
Files 39 39
Lines 1634 1636 +2
Branches 174 175 +1
=========================================
+ Hits 1175 1177 +2
- Misses 339 340 +1
+ Partials 120 119 -1 |
|
cc @segmentio/gateway |
|
Were there no tests for this codepath? |
|
Yeah there weren't, at least I didn't see any. We'll add new ones before this gets merged though. |
danielstjules
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
https://paper.dropbox.com/doc/Sending-Disabled-Events-evdrvByT2cYUErnrbAUa3