Use DEBUG preprocessor flag to conditionally disable assertions in prod #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
reviewed
Sep 15, 2017
| @@ -146,6 +146,7 @@ static id SEGCoerceJSONObject(id obj) | |||
|
|
|||
| static void AssertDictionaryTypes(id dict) | |||
| { | |||
| #ifdef DEBUG | |||
There was a problem hiding this comment.
This should be #if DEBUG.
If DEBUG is defined as 0 this would evaluate as true :)
There was a problem hiding this comment.
Good point. However in practice that's not how most projects (including Pods.xcodeproj) are setup though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ladanazita @TeresaNesteby
Tested manually w/ @TeresaNesteby in test app and confirmed working.