Fix NSURLSession being prematurely invalidated #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested manually and working |
Codecov Report
@@ Coverage Diff @@
## master #702 +/- ##
=========================================
- Coverage 72.76% 72.46% -0.3%
=========================================
Files 39 39
Lines 1623 1620 -3
Branches 171 171
=========================================
- Hits 1181 1174 -7
- Misses 327 329 +2
- Partials 115 117 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two separate PRs unfortunately introduced conflicting changes
#699
#679
When we re-use session, we should no longer invalidate session right after each task.