Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a missing import, which was causing a compiler warning, when using Segment Analytics via Carthage, in a project completely written in Swift.
Where should the reviewer start?
carthage bootstrap platform iOS
As a result, you'll get the compiler warning mentioned above.
How should this be manually tested?
Yes!. Map the Sample App's Cartfile to
giorgiopaoloni/analytics-ios
branchdev
instead, and verify the warning is gone. Note that your Cartfile should look as follows:Any background context you want to provide?
Not really!
What are the relevant tickets?
N/A
Screenshots or screencasts (if UI/UX change)
N/A
Questions:
Does the docs need an update?
No need to.
Are there any security concerns?
No sir!
Do we need to update engineering / success?
No. Keep up the good work, thanks for helping us out!!
@segmentio/gateway
cc @fredrocious