Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEGIntegration: Importing Context #700

Merged
merged 1 commit into from Nov 23, 2017
Merged

SEGIntegration: Importing Context #700

merged 1 commit into from Nov 23, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 27, 2017

What does this PR do?
This PR adds a missing import, which was causing a compiler warning, when using Segment Analytics via Carthage, in a project completely written in Swift.

screen shot 2017-06-26 at 11 06 57 pm

Where should the reviewer start?

  1. Check out this sample app
  2. Run carthage bootstrap platform iOS
  3. Build the sample project

As a result, you'll get the compiler warning mentioned above.

How should this be manually tested?
Yes!. Map the Sample App's Cartfile to giorgiopaoloni/analytics-ios branch dev instead, and verify the warning is gone. Note that your Cartfile should look as follows:

github "giorgiopaoloni/analytics-ios" "dev"

Any background context you want to provide?
Not really!

What are the relevant tickets?
N/A

Screenshots or screencasts (if UI/UX change)
N/A

Questions:

  • Does the docs need an update?
    No need to.

  • Are there any security concerns?
    No sir!

  • Do we need to update engineering / success?
    No. Keep up the good work, thanks for helping us out!!

@segmentio/gateway

cc @fredrocious

@codecov-io
Copy link

codecov-io commented Jun 27, 2017

Codecov Report

Merging #700 into dev will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #700      +/-   ##
==========================================
- Coverage   72.52%   72.39%   -0.13%     
==========================================
  Files          39       39              
  Lines        1623     1623              
  Branches      171      171              
==========================================
- Hits         1177     1175       -2     
- Misses        329      331       +2     
  Partials      117      117

@f2prateek
Copy link
Contributor

Sorry for the delay, thanks for this!

@f2prateek f2prateek merged commit 1a820cb into segmentio:dev Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants