Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STRATCONN-4300] [Klaviyo] Add Multistatus Support for Upsert Profile #2620

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

harsh-joshi99
Copy link
Contributor

@harsh-joshi99 harsh-joshi99 commented Dec 2, 2024

This PR adds multistatus support for klaviyo upsert profile action.

JIRA -> https://segment.atlassian.net/browse/STRATCONN-4300

Testing

Testing Successfully completed in staging.
Testing document.

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@harsh-joshi99 harsh-joshi99 changed the title [STRATCONN 4300] Add Multistatus Support for Klaviyo Upsert Profile [STRATCONN-4300] [Klaniyo] Add Multistatus Support for Upsert Profile Dec 2, 2024
@harsh-joshi99 harsh-joshi99 changed the title [STRATCONN-4300] [Klaniyo] Add Multistatus Support for Upsert Profile [STRATCONN-4300] [Klaviyo] Add Multistatus Support for Upsert Profile Dec 2, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.62%. Comparing base (dda2c53) to head (56f311d).
Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
...tion-actions/src/destinations/klaviyo/functions.ts 91.42% 2 Missing and 4 partials ⚠️
...ns/src/destinations/klaviyo/upsertProfile/index.ts 87.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2620      +/-   ##
==========================================
+ Coverage   78.00%   78.62%   +0.62%     
==========================================
  Files         991     1030      +39     
  Lines       17388    18248     +860     
  Branches     3281     3432     +151     
==========================================
+ Hits        13563    14347     +784     
- Misses       2737     2756      +19     
- Partials     1088     1145      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harsh-joshi99 harsh-joshi99 marked this pull request as ready for review December 3, 2024 05:24
@harsh-joshi99 harsh-joshi99 requested a review from a team as a code owner December 3, 2024 05:24
@itsarijitray
Copy link
Contributor

Seems like there are some conflicts. Can you resolve them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants