Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Klaviyo] |Add MultistatusResponse to RemoveProfile and RemoveProfilefromList #2607

Merged
merged 8 commits into from
Dec 12, 2024

Conversation

Innovative-GauravKochar
Copy link
Contributor

@Innovative-GauravKochar Innovative-GauravKochar commented Nov 20, 2024

Jira tickets
Remove Profile
Remove Profile From List Via Engage

This Pull request aims to add multiStatusResponse support for the RemoveProfile and RemoveProfileFromList action of Klaviyo(Actions).

Local & Stage Testing Documentation
Remove Profile
Remove Profile From List Via Engage

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.45%. Comparing base (59fe0e6) to head (b89f6c9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...tion-actions/src/destinations/klaviyo/functions.ts 95.34% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2607      +/-   ##
==========================================
+ Coverage   78.43%   78.45%   +0.01%     
==========================================
  Files        1030     1030              
  Lines       18343    18346       +3     
  Branches     3473     3474       +1     
==========================================
+ Hits        14388    14394       +6     
+ Misses       2799     2796       -3     
  Partials     1156     1156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sayan-das-in
sayan-das-in previously approved these changes Nov 30, 2024
itsarijitray
itsarijitray previously approved these changes Dec 10, 2024
@joe-ayoub-segment joe-ayoub-segment enabled auto-merge (squash) December 12, 2024 15:24
@joe-ayoub-segment joe-ayoub-segment merged commit 53ed4c4 into main Dec 12, 2024
14 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the klaviyo-removeProfile branch December 12, 2024 15:30
@joe-ayoub-segment
Copy link
Contributor

PR deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants